I used to collect old hunting and gun stuff to decorate my man cave. I found cans like yours and old gun cleaning product tins in antique shops for fairly reasonable prices compared to other antique items that were more popular.
It's been ten years since I've seriously looked as I bought more than I can use. Prices have gone crazy on wood decoys since but doubt if old cans have followed. It's still a fun hobby to collect stuff like that and my buddies love my man cave decorated with that sort of thing.

I'd look for a shop or site into he-man collectibles if I was trying to sell those at a profit. I've found some booths like that in antique shops and their prices are always much higher than the regular booths on such items.