I prefer Winchester brass without case cannelures. Second choice, Winchester wadcutter brass with the case cannelures. Third choice, any other American brass, Speer, Federal, whatever.
Second to last choice, foreign .38 brass. Last choice, Remington .38 brass. The foreign stuff usually has thicker walls at the base. The Remington is thin and has difficulty with bullet tension on shorter bullets. But Remington is good for 148gr HBWC.
Brass with cannelures does not last as long, though in the case of wadcutter brass it may be more accurate.
Some reloaders don't like nickel cases and swear they don't last as long. That's not my experience but I don't really care for nickel. I save them for defensive ammo reloads.
Preferred primer in order: Winchester, Remington, CCI but they are all pretty close.
I've loaded over 100,000 rounds of .38 Special ammo over a few ..... decades.