There are many variables to consider - noise, lighting, airflow, rain, temperature, drive distance, shooting distances, ability to shoot reloaded ammo, etc
I prefer shooting outside unless it's cold, raining, or too windy. Thankfully my city has opened 2 indoor ranges in the last year. Previously there were none. One of them just opened last week. The newest one allows you to shoot reloads whereas the first one did not. Since 90% of my shooting is reloads I rarely visited the range that's been around for a year now.
Indoor ranges are fine for pistol distances but most people aren't too interested in shooting rifles at 25 yards.