Lots of choices, but what works for you is what matters
When I got my first M19, I decided to try a variety of ammo and see what shot most accurately. That was the Speer GDHP, but with DPX a close second. If I were to carry that gun, I'd use the Speer stuff.
My second M19 liked the Federal Classic 158 best, and I'm confident that would be an efficient choice. My M65 really likes the Speer GDHP, and my pre-27 likes the Hornady 140 XPT and Federal Classic. So I keep a few boxes of Speer and Fed Classic.
In the end, what you shoot for practice is probably most important, as that's what you'll use most. For carry, I'd pick the ammo that shoots best; given the odds of actually using it and the power of the .357, having the edge of accuracy is probably more important than the particular load. Confidence in accuracy is always good.