When I first started carrying concealed, my favorite color was tan. While I still like the color, I quickly realized that black is a much more practical color for CCW because if it happens to peek out from under a shirt, the black will blend in so much better than a light tan colored holster, especially when wearing dark blue jeans. Black is just a more neutral and more concealable color IMHO.
Because of that I either bought new holsters or had them dyed black. Now I will only buy black holsters, belts and ammo carriers. While I do have a few tan holsters left, I rarely use them.
There are a few exceptions..... My two holster Cowboy Rigs are all tan but I am not trying to conceal them at all. They were worn at SASS matches and at competitions. I still wear them on private property when informal "cowboy shootin' is done and where I am not in the public eye so the color doesn't matter.