I like this answer from Century Spring, a huge spring manufacturer for years:
The effective life of a compression spring depends heavily on the operating environment. A spring designed for a static application with a properly chosen material should last indefinitely. In cyclic applications...