Just my opinion, but I think buying a gun as a financial investment is not the best reason to get one. Get one because you like it. If it happens to have investment potential, then that's a bonus.
With that said, I'd say getting one of the rarer, harder-to-find models might pay dividends down...