I've been a member off and on since I was a teen. The last few years I let it lapse. I renewed a little while back.
As others have said, I don't always agree with the way they handle things--I thought for one think that LaPierre didn't use the opportunity he had recently to make good points by talking real numbers about how little rifles are used in crimes, for example.
Of course I don't agree 100% with most any organization or person for that matter.
Lee (our fearless leader) said something in a recent post, to the effect that if you didn't like LaPierre's speech, send money so they can hire better writers and consultants. Lee has a way of distilling things sometimes.
I do think they're gotten back on track and Keene has been doing a fine job in the interviews I've heard lately.
And as others have said, they are the ones doing most to protect our rights, and to limit the reach of the feds with respect to fiddling with the constitution. Redlevel put it very well in his post.
If you haven't joined yet, you should.